match-lms-release: remove NPM_TOKEN#44
Merged
Merged
Conversation
cfbao
changed the title
svanherk
approved these changes
Jun 15, 2026
| @@ -43,7 +43,6 @@ Options: | |||
| * `DRY_RUN` (default: `false`): Simulates a release but does not actually do one | |||
| * `GITHUB_TOKEN`: Token to use to update version in 'package.json' and create the tag -- see section below on the release token for more details | |||
| * `NPM` (default: `false`): Whether or not to release as an NPM package (see "NPM Package Deployment" below for more info) | |||
Contributor
There was a problem hiding this comment.
In hindsight, while this is technically accurate, I wish we'd called this something else. Like PUBLISH or whatever. Cause now's it's just kinda confusing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not seeing any usage of this action for publishing to public NPM.
All existing usages are for publishing to CodeArtifact.
All existing usages of the
NPM_TOKENinput are incorrect, and I'm opening PRs to remove them:https://github.com/pulls/search?q=is%3Apr+author%3Acfbao+%22remove+unnecessary+NPM_TOKEN+from+match-lms-release%22
HOD-4564 - Proxy Registry > Mass update repos