Merged
Conversation
Updated effect descriptions and added preview links for various effects in the README.
There was a problem hiding this comment.
Pull request overview
Updates the effects documentation to include preview media links and refactors some effect property handling to use a single color field (via a new Entity.GetColor(...) extension) for improved usability in the editor.
Changes:
- Replace per-effect local preview media links with GitHub “user-attachments” preview URLs in
docs/effects/README.md. - Refactor
Color TintandFogeffects fromr/g/b/alphaproperties to a singlecolorproperty. - Add
EntityExtensions.GetColor(...)helper and delete theZoomPulseEffectimplementation file.
Reviewed changes
Copilot reviewed 6 out of 20 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
docs/effects/README.md |
Updates effect descriptions/properties and swaps preview media references to external URLs; removes Zoom Pulse section. |
BopVisualEffects/Effects/ColorTint/ColorTintEffect.cs |
Switches template + runtime property reading to a single color field. |
BopVisualEffects/Effects/Fog/FogEffect.cs |
Switches template + runtime property reading to a single color field. |
BopVisualEffects/Core/EntityExtensions.cs |
Adds GetColor extension for reading colors from entity properties. |
BopVisualEffects/Effects/ZoomPulse/ZoomPulseEffect.cs |
Removed effect implementation (now missing from codebase). |
docs/effects/zoom-pulse/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/zoom-out/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/zoom-in/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/vignette/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/sepia/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/screen-noise/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/scanlines/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/pixel-grid/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/letterbox/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/hsl-filter/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/fog/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/color-tint/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/camera-tilt/.gitkeep |
Keeps effect media directory present (no actual media committed). |
docs/effects/camera-shake/.gitkeep |
Keeps effect media directory present (no actual media committed). |
Contributor
2 tasks
…-repo (#24) * Initial plan * Update README to reflect new preview video requirements (upload .mp4 to GitHub, no in-repo storage) Co-authored-by: Brollyy <12004018+Brollyy@users.noreply.github.com> * Add placeholder instruction for preview video in copilot-instructions.md Co-authored-by: Brollyy <12004018+Brollyy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Brollyy <12004018+Brollyy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added preview videos for effects and did some refactors for usability.