feat: Adjust the OHIF Viewer to support events related to the custom toolbar [CWLF-390]#2
Open
damian-lis-butterfly wants to merge 1 commit intomasterfrom
Open
feat: Adjust the OHIF Viewer to support events related to the custom toolbar [CWLF-390]#2damian-lis-butterfly wants to merge 1 commit intomasterfrom
damian-lis-butterfly wants to merge 1 commit intomasterfrom
Conversation
damian-lis-butterfly
force-pushed
the
ohif_implementation
branch
from
ea80ec0 to
91e8e49
Compare
damian-lis-butterfly
changed the title
…toolbar [CWLF-390]
damian-lis-butterfly
force-pushed
the
ohif_implementation
branch
from
91e8e49 to
11ec5e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The work in this PR is based on Gino’s implementation, described here:
https://butterflynetwork.atlassian.net/wiki/spaces/~619288566d002b006bfd2d47/pages/4177199143/OHIF+Viewer+in+Cloud+Findings
Summary
In this PR, I have:
ButterflyProvidercomponent to handle events from the custom toolbar implemented inhttps://github.com/ButterflyNetwork/olympus-frontend/pull/7695,
InlineAnnotationInputcomponent to replace the default one, so it matches our design requirements(styles will be further refined to align with our design system),
• commenting out specific code, and
• adding the hideUI option to the
default.jsconfig file.Note
butterfly.jsconfig file will be used once the backend is ready. For now, the application usesdefault.js.How to use the OHIF viewer in
olympus-frontendPUBLIC_URL=/static/ohif/ yarn run builddistfolder intoolympus-frontend(see the exact placement instruction in this PR:https://github.com/ButterflyNetwork/olympus-frontend/pull/7695)
Work on the OHIF viewer has been paused for some time, so a detailed review isn’t necessary at the moment, as some aspects may still change.