Open
Conversation
…e set against different item variants
Rover656
commented
Feb 21, 2026
| import java.util.Set; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| // TODO: Should cache results. |
Author
There was a problem hiding this comment.
Will handle this if you're happy with the idea :)
Author
|
We could also potentially consider adding mod compat (like Ender IO) into Replication itself, but I don't want to drop other mod code into your mod unless you're happy with that :) |
Author
|
Discovered a crash when clicking on matter types in the terminal ( |
Owner
|
I will check it out soon, any change to the recipe calculation scares me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #80 for problem description.
The first commit was my initial attempt at adding support for components by simply declaring which components should be copied, however I decided to re-do this change instead by adding an API for specifying item variants.
The idea here is to allow mods to declare items which have variants based on item data - For example, this is what the Ender IO compat would look like:
This is a very rough draft to seek approval and input before polishing this up :) Hopefully you're happy with this approach.