Open
Conversation
SmorodinVik
reviewed
Oct 30, 2024
| const Radio = ({ value, children }: IRadioProps): JSX.Element => { | ||
| const { name, value: groupValue, setValue } = useRadioGroupContext(); | ||
|
|
||
| const radioId = useMemo(() => `${name}-${value}`, [name, value]); |
Contributor
There was a problem hiding this comment.
зачем тут useMemo и useCallback чуть ниже?
Contributor
Author
There was a problem hiding this comment.
Можно убрать да. Я тут эксперимертировал с ререндером
|
|
||
| return { | ||
| name, | ||
| value: _value, |
Contributor
There was a problem hiding this comment.
не понял смысл нижнего подчеркивания у _value, почему нельзя просто value назвать и его отдать?
Contributor
Author
There was a problem hiding this comment.
Раньше value пропс был. Это рудимент. Уберу
| (targetValue: string) => { | ||
| setValue(targetValue); | ||
|
|
||
| if (onChange) { |
Contributor
There was a problem hiding this comment.
можно сократить до onChange?.(targetValue);
Contributor
Author
|
Надо дописать тесты |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.