Open
Conversation
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json # tsconfig.json
# Conflicts: # packages/types/src/index.ts
ancientbag
reviewed
Oct 31, 2024
This reverts commit 5aee8b5.
ancientbag
reviewed
Nov 30, 2024
|
|
||
| export type TStorageValueDeserializer<T> = (raw: string) => T; | ||
|
|
||
| export interface IStorageService<TValue> { |
Contributor
There was a problem hiding this comment.
Если я правильно понимаю, то данный интерфейс нужен для того чтобы его заэкстендить в разных хранилищах (LocalStorage, ServiceStorage).
При текущей конструкции для обращения к хранилищам нужно заводить новые инстансы, т.к. методы getValue и setValue всегда возвращают дженерик TValue.
Так ли нужен этот дженерик? Я бы вынес дженерики из инстанса в методы getValue и setValue.
Таким образом инстанс хранилища можно было бы объявить один раз. И при использовании гет или сет, явно указывать возвращаемый тип
# Conflicts: # package-lock.json # package.json
# Conflicts: # package-lock.json # packages/types/package.json # packages/types/src/index.ts
pixel-fixer
assigned
pixel-fixer and
sadcitizen and unassigned
sadcitizen and
pixel-fixer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.