ftp: Replace fakeDataConn with mockery#301
Open
NathanBaulch wants to merge 1 commit intoC2FO:mainfrom
Open
Conversation
Contributor
Author
|
Just a flakey test I guess. |
NathanBaulch
force-pushed
the
fakedataconn
branch
3 times, most recently
from
60c43da to
9b17bdc
Compare
NathanBaulch
changed the title
NathanBaulch
force-pushed
the
fakedataconn
branch
from
9b17bdc to
297440b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
fakeDataConnmock in the ftp backend and switch to using mockery instead. This removes a fair bit of mocking boilerplate, along with thedsoprea/go-utilitydependency which is no longer needed.