Tests and improvements

[MattiSG]

Hi Christopher,

Here are some improvements I made to Locate :)

They are all keeping compatibility with your original code, but I would recommend that you take a look at my MSG branch, which breaks compatibility with Locate < 1.3, but is IMHO cleaner (still needs improvements over address getting, but since we have dependencies to Google Maps anyway, I'm thinking about extracting this into yet another file and use Gmaps API v3).

I'm not sure if you had tested your distanceTo() method, but according to my test file your original version does not calculate properly… Again, if you can confirm this, please consider integrating my MSG branch :)

Thanks for the original code!

Greetings,
Matti

[CBeloch]

Hi,
I'll take a look at your changes and may merge them into the original Locate.js.
The first things I've seen were good changes, but I have to take a closer look at everything when I have more time.
I've made some tests to the distanceTo() as far as I could (testing it with the distance to work etc) and it looked quite good, but I could recheck this and maybe check the distance between 2 clients etc :)

Thank you for your changes!
People like you are why I love to work open-source =)

I will give you a hint (and credits) when I merge everything together!

Greetings,
Chris

[MattiSG]

Woops, I just realized that I had messed up with my branches!!
The pull request I sent includes most of my MSG branch changes, which are my own take to the implementation (even though they are sent with justification); please consider this as optional, it's really up to you to decide whether you want my refactor to make it to your master :)

The pull request should concern only my master branch up to commit 38d9053d4956f2b30df3, plus the 653070eb9c59f3b6f7b4 commit that adds tests. I won't clean this up immediately, in case you decide to include my MSG changes, but I am really not trying to force this on you, you can decide to merge only the improvements, not my architectural considerations ;)