Standardize output figures across MOSuite function calls#223
Open
phoman14 wants to merge 13 commits into
Open
Conversation
Use the MOSuite palette as the hardcoded filter and normalize plot color default, extend short explicit palettes through the selected palette path, and keep random colors as the get_colors_vctr fallback. Update docs, JSON defaults, and focused color/filter/normalize tests.
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 79.66% 79.71% +0.04%
==========================================
Files 22 22
Lines 3398 3534 +136
==========================================
+ Hits 2707 2817 +110
- Misses 691 717 +26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR standardizes the appearance of MOSuite output figures across direct plotting calls, workflow calls, and the matching Code Ocean capsules. The intent is that the same data and grouping metadata produce consistent colors, category order, point sizing, and readable legends whether a figure is created by
plot_pca_2d(),plot_pca_3d(),plot_histogram(),filter_counts(),normalize_counts(), or an affected capsule.Changes
get_mosuite_colors()available for later use.filter_counts()andnormalize_counts()with the defaults exposed by the affected capsules.NEWS.mdfor the user-facing figure default changes.Affected capsule repos from these package changes:
Validation:
test-plot_pca.R:PASS 21test-plot_histogram.R:PASS 14test-filter.R:PASS 27test-normalize.R:PASS 22Issues
No linked issue.
PR Checklist
(
Strikethroughany points that are not applicable.)NEWS.mdwith a short description of any user-facing changes and reference the PR number. Follow the style described in https://style.tidyverse.org/news.htmldevtools::check()locally and fix all notes, warnings, and errors. Focused package tests passed; fulldevtools::check()was not run in this session.