Skip to content

[Feat][개발 환경 설정] RTK 추가#16

Open
akdlsz21 wants to merge 8 commits intomainfrom
feat/12
Open

[Feat][개발 환경 설정] RTK 추가#16
akdlsz21 wants to merge 8 commits intomainfrom
feat/12

Conversation

@akdlsz21
Copy link
Copy Markdown
Contributor

Feature

  • redux toolkit 추가

@akdlsz21 akdlsz21 requested a review from ysh4296 July 12, 2022 11:13
@akdlsz21 akdlsz21 self-assigned this Jul 12, 2022
import { CacheProvider, EmotionCache } from '@emotion/react';
import theme from '@theme/light';
import createEmotionCache from 'emotion_cache/createEmotionCache';
// Redux
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 꼭필요한거 아님 제거하죠

import createEmotionCache from 'emotion_cache/createEmotionCache';
// Redux
import { Provider } from 'react-redux';
import { store } from '../src/store/store';
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@store 통해 불러오도록 해주세요! 폴더 이름도 좀더 구분 가능한걸로 바꾸어주실 수 있나요?

pages/_app.tsx Outdated
<CacheProvider value={emotionCache}>
<ThemeProvider theme={theme}>
{/* CssBaseline kickstart an elegant, consistent, and simple baseline to build upon. */}
<CssBaseline />
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 주석이 남아있긴 했네요 이거 제거해주세요!

@@ -0,0 +1,29 @@
import { configureStore } from '@reduxjs/toolkit';
// import userSlice from './slices/userSlice';
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이쪽도 주석 다 제거해주실 수 있나요?

@@ -0,0 +1,8 @@
import React from 'react';
import { Button, Typography } from '@mui/material';
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미사용임포트는 제거해주세요


const StyledBox = styled(Box)<BoxProps>(({ theme }) => ({
marginTop: '4px',
marginTop: '4px',// 1 하면 딱 좋더라
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 주석 삭제해주세요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants