Skip to content

Conversation

@Neeraj-gagat
Copy link
Contributor

Description

added shortcuts for addtaskdialog
now user can navigate and chose feilds to edit by arrow keys
did little chnages in ui of addtaskdialog to show highlighted/focused feild

- Fixes: #319

video after chnages

Screencast.from.15-01-26.11.07.43.PM.IST.webm

note: let me know if this is good to go then i will add tests for shortcuts

@github-actions
Copy link

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

Copy link
Collaborator

@its-me-abhishek its-me-abhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

There also seems to be a visual bug, the Add in Add task is hazy. Needs to be fixed.
Overall PR looks Good, do fix these, and also maybe reduce height of the fields by a bit, so as to fit in more content. Will merge later

@@ -1,4 +1,4 @@
import { FIELDS } from '../HomeComponents/Tasks/constants';
import { ADD_FIELDS, FIELDS } from '../HomeComponents/Tasks/constants';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly rename fields and add_fields to better variable names.

e.preventDefault();
}

// ✅ allow enter to open dropdown
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do remove these comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more keyboard shortcuts using hotkeys

2 participants