Conversation
jolson490
reviewed
May 4, 2026
jolson490
previously approved these changes
May 4, 2026
|
jolson490
reviewed
May 4, 2026
| } | ||
|
|
||
| variable "subnets" { | ||
| type = map(object({ |
Contributor
There was a problem hiding this comment.
Hey there @mww59 . I'm pretty sure there's a merge functionality with Terraform and a map, so that the caller of a module can pass in just the parts they want to specify/change, and the rest of the map doesn't have to be specified anywhere (e.g. the optional lines here). I'd have to look into it more. I think this is good for now, and we could simplify this code later.
Contributor
There was a problem hiding this comment.
Please feel free to let me know Mike when this PR is no longer a draft, and then I'll promptly (re-)review it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a Virtual Network for NBS