Conversation
mww59
requested review from
EmmanuelNwa247,
cmansky,
jolson490,
rin-skylight and
szamfir-skylight
as code owners
| @@ -0,0 +1,8 @@ | |||
| module "acr" { | |||
There was a problem hiding this comment.
Dependent on ACR PR on if this will need changes. Let's hold on merge until that comment is resolved.
| @@ -0,0 +1,8 @@ | |||
| module "vnet" { | |||
There was a problem hiding this comment.
If we have to start offering some resources be disabled and some enabled then they should all have an enabled flag. Something to consider in previous modules build
| @@ -0,0 +1,14 @@ | |||
| module "nbs6-agw-private" { | |||
There was a problem hiding this comment.
this one should probably be optional as well given nbs6 aci is removed
| @@ -1,13 +1,15 @@ | |||
| module "agw_public" { | |||
There was a problem hiding this comment.
For this I was thinking we would have a single public app gateway with both public and private routes, instead of 2.
| @@ -0,0 +1,4 @@ | |||
| module "argocd" { | |||
There was a problem hiding this comment.
We should remove argocd from samples since this should be archived
| @@ -0,0 +1,14 @@ | |||
| terraform { | |||
There was a problem hiding this comment.
I might be missing something on this one, but regarding application deployment to the AKS cluster. Shouldn't there be a reference to it? Can you point me to where that connection happens?
|
3 participants
First pass at layered Terraform samples for Azure. Modules have been tested with successful applies in a local environment.
Previous samples have been moved to archive.