Skip to content

APP-432 - Validate incoming /nbs/api/report/execute requests#3140

Open
JordanGuinn wants to merge 57 commits into
mainfrom
jg/APP-432
Open

APP-432 - Validate incoming /nbs/api/report/execute requests#3140
JordanGuinn wants to merge 57 commits into
mainfrom
jg/APP-432

Conversation

@JordanGuinn
Copy link
Copy Markdown
Contributor

@JordanGuinn JordanGuinn commented Apr 7, 2026 •
edited
Loading

Description

This PR adds some initial validation to the /nbs/api/report/run and /nbs/api/report/export endpoints, particularly around the shape of the incoming request, along with the presence and format of expected fields.

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@JordanGuinn JordanGuinn changed the title APP-432 - Validate /nbs/api/report/execute requests (WIP) APP-432 - Validate /nbs/api/report/execute requests Apr 7, 2026
@JordanGuinn JordanGuinn changed the title (WIP) APP-432 - Validate /nbs/api/report/execute requests APP-432 - Validate incoming /nbs/api/report/execute requests Apr 23, 2026
mcmcgrath13
mcmcgrath13 reviewed May 7, 2026
View reviewed changes
Comment thread testing/regression/cypress/step_definitions/reports-api/export.steps.js Outdated
mcmcgrath13
mcmcgrath13 reviewed May 7, 2026
View reviewed changes
Comment thread testing/regression/cypress/step_definitions/reports-api/export.steps.js Outdated
mcmcgrath13
mcmcgrath13 reviewed May 7, 2026
View reviewed changes
Comment thread testing/regression/cypress/step_definitions/reports-api/run.steps.js Outdated
emyl3
emyl3 reviewed May 7, 2026
View reviewed changes
Comment thread testing/regression/cypress/step_definitions/reports-api.steps.js
mcmcgrath13
mcmcgrath13 reviewed May 7, 2026
View reviewed changes
Comment thread apps/modernization-api/src/main/java/gov/cdc/nbs/report/models/Expr.java
mcmcgrath13
mcmcgrath13 reviewed May 7, 2026
View reviewed changes
Comment thread testing/regression/cypress/step_definitions/reports-api.steps.js Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube Cloud

@JordanGuinn JordanGuinn requested review from emyl3 and mcmcgrath13 May 12, 2026 04:48
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 12, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
83.3% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube Cloud

emyl3
emyl3 approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, Jordan!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emyl3 emyl3 emyl3 approved these changes

@mcmcgrath13 mcmcgrath13 Awaiting requested review from mcmcgrath13

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JordanGuinn @emyl3 @mcmcgrath13