[APP-524] feat: advanced filter setup#3197
Conversation
…into mcm/adv-filt-ui
| @Schema(requiredMode = Schema.RequiredMode.REQUIRED) String name, | ||
| @Schema(requiredMode = Schema.RequiredMode.REQUIRED) String title, | ||
| @Schema(requiredMode = Schema.RequiredMode.REQUIRED) String sourceTypeCode, |
There was a problem hiding this comment.
these are all required in the UI and are always populated in practice, without them, things don't work
There was a problem hiding this comment.
sugg, nb: Might be worth an inline comment so future folks know why it's there
| .collapsible { | ||
| @include expanded('height'); | ||
| overflow: hidden; | ||
| overflow: visible; |
There was a problem hiding this comment.
this fixes the weird card clipping pop up date pickers and multi-select drop downs
| columnSourceTypeCode?: string; | ||
| maxLength?: number; | ||
| name: string; | ||
| title: string; |
There was a problem hiding this comment.
simplify names for the API since we already know we're in the context of a column
mcmcgrath13
changed the title
mcmcgrath13
requested review from
brick-green and
krista-skylight
and removed request for
a team
There was a problem hiding this comment.
Super minor sugg, nb: maybe move the constants to another file for organization since this module is a bit long? Not super opinionated on this though.
There was a problem hiding this comment.
I kept flip flopping on whether to split or not. It all felt a bit arbitrary, so I left with comment sectioning, but I feel 🥴 🤷 about it
krista-skylight
left a comment
krista-skylight
left a comment
There was a problem hiding this comment.
Just left a couple minor suggestions! To answer your question, I don't think doing translations seems that cumbersome so if I had to pick I think staying with columnUid is fine.
|
2 participants
Description
Wire up the query builder to use for the advanced filter builder
Notes:
ReportColumna bit tighter and better matching of the reality of what's required for the app to function (which doesn't match db required-ness 😭 )mm/dd/yyyyas we have in the DB - when we swap to our datepicker, this should be fixedid_prefix so they'd be treated as object keys instead (the ids can be pretty big and don't need to create that large of an array)Questions:
fieldon the config/request, it's currently the columnUid, but in practice we have to translate this to the column's name for the query builder to work. Given we need to translate, should we a) have the field just be the column name? (makes validation kinda weaker perhaps? though maybe not as we still know what column names are valid in the context of the report/filter)Tickets
Checklist before requesting a review