APP-489: Convert NBSSR00010 (Multi-Year Line Graph of Disease Cases)#3209
Conversation
| ('NBSSR00008.SAS', 'SR8: Report of Disease Cases Over Selected Time Period. Report demonstrates, in table form, the total number of Investigation(s) [both Individual and Summary] by County irrespective of Case Status.'), | ||
| ('NBSSR00009.SAS', 'SR9: Selected Disease by Month and County. Report demonstrates the total number of monthly Investigation(s) [both Individual and Summary] for a given disease and State, by County, irrespective of Case Status.'), | ||
| ('NBSSR00010.SAS', 'SR10: Multi-Year Line Graph of Disease Cases. Report demonstrates, using a multi-year line graph, the total number of yearly Investigation(s) [both Individual and Summary] for a given disease, by State, irrespective of Case Status.'), | ||
| ('NBSSR00010.SAS', 'SR10: Multi-Year Line Graph of Disease Cases. Report demonstrates, in table form, the total number of yearly Investigation(s) [both Individual and Summary] for a given disease, by State, irrespective of Case Status.'), |
There was a problem hiding this comment.
Not sure what we want to do about the name of the report here - Multi-Year Line Graph is in the title 😬 Do we want to simply rename it?
There was a problem hiding this comment.
I think I'd leave it since this is one we're not directly replacing and are ultimately deleting this data if all goes well
JordanGuinn
requested review from
brick-green and
mcmcgrath13
and removed request for
a team
|
@JordanGuinn I don't see the functional testing CSVs in the library catalog - can you upload? |
|
@mcmcgrath13 Will do, just wanted to get enough data in the reports first so that comparisons were relatively meaningful. |
| YEAR(event_date) as [Year], | ||
| SUM(group_case_cnt) as [Cases] | ||
| FROM subset | ||
| WHERE event_date IS NOT NULL |
There was a problem hiding this comment.
Added this to avoid discrepancies found during functional testing for both 11 and 10.
|
I ran diff, but it looks like there's a bunch of wonky whitespace on the python version - any ideas? |
|
found the padding issue: #3210 |
|
@mcmcgrath13 Python report for testing has been regenerated and re-uploaded! |
|
I'm still seeing non-printable character/new line discrepancies on the diff, which makes the diff noisy - any ideas why? |
|
Finally realized that the failing regression test is not in fact a flaky test, but the result of the conversion/modernization of the SR10 report. The test currently resides in the
|
|
2 participants
Description
This PR converts NBSSR00010 to Python (which is effectively just NBSSR00011 in line-graph form).
Tickets
Checklist before requesting a review
apps/modernization-api/src/main/resources/db/changelog/report/execution/03_ODSE_Data_Report_Library_Init.sqlapps/modernization-api/src/main/resources/db/report/execution/librariesnamed<your library name>.sqlapps/modernization-api/src/main/resources/db/report-execution-changelog.yml. It should be added to the latestchangeSetsince the last release - this could require a newchangeSetif there isn't one since last releaseapps/report-execution/src/librariesnamed in lowercase, but generally following the naming convention of SAS (needs to be human recognizable as the same library)executefunction is the required method and its signature will (someday) be checked for validityapps/report-execution/tests/libraries/<your_library_here>pyfile following the conventions established for other librariessubset_sqlcan be assumed to be well tested by the modernization-api, so focus on any logic and additional joins/queries/analysis that is added in the library