Skip to content

Adding additional e2e tests#542

Open
robertandremitchell wants to merge 4 commits into
mainfrom
rob/522-additional-e2e-test-eicrs
Open

Adding additional e2e tests#542
robertandremitchell wants to merge 4 commits into
mainfrom
rob/522-additional-e2e-test-eicrs

Conversation

@robertandremitchell
Copy link
Copy Markdown
Collaborator

Description

Adds additional dummy eicrs to tests

I also included a known fail one. If we do have to pursue logic that requires us to route through all of APHL's plumbing, I thought it might be good to start thinking about how that routing might need to change or what success looks like.

Related Issues

Closes #522

Additional Notes

[Add any additional context or notes that reviewers should know about.]

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@robertandremitchell robertandremitchell linked an issue May 11, 2026 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.78%. Comparing base (c02179e) to head (d20d673).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files          46       46           
  Lines        2372     2372           
=======================================
  Hits         2272     2272           
  Misses        100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional e2e test eICRs

2 participants