Add TF Config and Index Lambda Extension#546
Open
bamader wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
- Coverage 95.81% 95.75% -0.07%
==========================================
Files 46 46
Lines 2344 2378 +34
==========================================
+ Hits 2246 2277 +31
- Misses 98 101 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR manages the terraform and the index lambda portion of creating a result cache for previously seen eICR inputs. In terraform, this change set includes:
In the Index Lambda, this PR extends the existing functionality to also apply to the Result Cache index by defining some new actions (basically just counterparts of the Vector Search Index) and re-using functions there. Unit tests are updated and new tests are added accordingly.
Finally, our Index Lambda previously had a set of kruft code which was a carryover from our very first embedding trial. The block of code dealing with checking whether the OpenSearch Index had knn vectors in its property mappings (in the create function) is now no longer necessary: (1) the result cache index does not use KNN embeddings, and (2) (more importantly) the only reason this code was originally there is because our first AWS index upload back in September of 2025 did not have this property set correctly for some of its vectors. When we went to create the index, we had to do an additional check to see whether the index first needed to be deleted so things could be freshly set. Now, though, all of our vectors have the same uniform properties set, so this is a non-issue and will not be a problem going forward. The unit test dealing with this behavior has also been deleted.
Related Issues
Partially addresses some tasks in #533 .