Adding code so eicr always flows to augmentation#559
Open
robertandremitchell wants to merge 9 commits into
Open
Adding code so eicr always flows to augmentation#559robertandremitchell wants to merge 9 commits into
robertandremitchell wants to merge 9 commits into
Conversation
…-flows-through-to-augmentationeicrv2
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 90.56% 90.85% +0.28%
==========================================
Files 48 48
Lines 2629 2711 +82
==========================================
+ Hits 2381 2463 +82
Misses 248 248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…rough without error
…-flows-through-to-augmentationeicrv2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a new passthrough logic to ttc-lambda to ensure that all eICR flow to AugmentationEICRV2/. This is necessary for APHL to pick up the eICR regardless of it needed augmentation and some uncovered exceptions.
ended up falling a little bit back into the e2e rabbit hole, as this change does impact (positively!) some "brittleness" I noticed/encountered on the last e2e ticket where augmented eicrs were getting tripped up because they didn't have any data needing augmenting. Now that we expect more eicrs to fully run end to end, I changed some of the logic there to reflect that. I can make that set of work a sub-branch of this ticket, if we prefer to review those two pieces of work separately.
Related Issues
Closes #545
Additional Notes
[Add any additional context or notes that reviewers should know about.]
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: