Skip to content

Adding code so eicr always flows to augmentation#559

Open
robertandremitchell wants to merge 9 commits into
mainfrom
rob/545-add-failsafe-so-original-eicr-always-flows-through-to-augmentationeicrv2
Open

Adding code so eicr always flows to augmentation#559
robertandremitchell wants to merge 9 commits into
mainfrom
rob/545-add-failsafe-so-original-eicr-always-flows-through-to-augmentationeicrv2

Conversation

@robertandremitchell
Copy link
Copy Markdown
Collaborator

@robertandremitchell robertandremitchell commented May 15, 2026

Description

This adds a new passthrough logic to ttc-lambda to ensure that all eICR flow to AugmentationEICRV2/. This is necessary for APHL to pick up the eICR regardless of it needed augmentation and some uncovered exceptions.

ended up falling a little bit back into the e2e rabbit hole, as this change does impact (positively!) some "brittleness" I noticed/encountered on the last e2e ticket where augmented eicrs were getting tripped up because they didn't have any data needing augmenting. Now that we expect more eicrs to fully run end to end, I changed some of the logic there to reflect that. I can make that set of work a sub-branch of this ticket, if we prefer to review those two pieces of work separately.

Related Issues

Closes #545

Additional Notes

[Add any additional context or notes that reviewers should know about.]

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.85%. Comparing base (36050be) to head (c7ad825).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   90.56%   90.85%   +0.28%     
==========================================
  Files          48       48              
  Lines        2629     2711      +82     
==========================================
+ Hits         2381     2463      +82     
  Misses        248      248              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robertandremitchell robertandremitchell changed the title Adding code to eicr always flows to augmentation Adding code so eicr always flows to augmentation May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add failsafe so original eICR always flows through to AugmentationEICRV2/

2 participants