-
Notifications
You must be signed in to change notification settings - Fork 2
Integrate logger client into cdp-client with service-based discovery #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
172f775
Initial commit
Karmo7 6e5c935
Update README.md
Karmo7 671a042
Initial implementation: logger, example usage, and tests
stefanrammo 96c1f87
Merge pull request #1 from stefanrammo/main
stefanrammo cbea695
Added support for Events and a test
stefanrammo a5b4810
Revert "Added support for Events and a test"
stefanrammo 9d10355
Added support for Events and a test
stefanrammo 7853884
Refactored event into a seperate example file
stefanrammo f3a7845
Updated README.md
stefanrammo d30440c
Fixed bugs
stefanrammo 6ef60ca
Merge pull request #4 from CDPTechnologies/AddedEventSupport
stefanrammo 0d8b2f0
Fixed pull request issues
stefanrammo 2cf2c24
Added sender and data conditions to event example
stefanrammo 423fedd
Merge pull request #5 from CDPTechnologies/FixesForAddedEventSupport
stefanrammo b51959b
Pull review #5 issues fixed
stefanrammo a6746e3
Added getEventCodeString method
stefanrammo 44133d4
Fixed comments
stefanrammo c0b9fce
Merge pull request #6 from CDPTechnologies/EventDataHandling
stefanrammo e912ad4
Match type added and restructuring client.js
stefanrammo 29a78d4
Merge pull request #7 from CDPTechnologies/MatchTypeFix
stefanrammo bdd29ee
Changed documentation and added objects: EventQueryFlags and MatchType
stefanrammo 0a7c4f1
Formatting
stefanrammo 6511630
Added Event Tags support and Count Events
stefanrammo 1b3465a
Added tests and fake data related to Event Tags
stefanrammo bec0606
Wrapped Client in a namespace cdplogger.Client
stefanrammo 0512a8a
Add GitHub Actions workflow for running tests
stefanrammo 50d5262
Update workflow to handle missing test directories
stefanrammo cc9d10c
Simplify workflow to run on single Node.js version
stefanrammo 4df8074
Add working GitHub Actions workflow for running tests
stefanrammo 3ebf57d
Added automatic test workflow
stefanrammo 189a984
Removed hardcoded port adding to url
stefanrammo f03f42f
Created a markdown file for docs and a quick start guide
stefanrammo bce99c9
Fixed documentation mistakes
stefanrammo f6aa706
NPM setup
stefanrammo dc2dad6
Updated package.json
stefanrammo b182d64
Added contacts to README
stefanrammo 15621e0
Updated docs
stefanrammo 3fdaba7
Changed name from cdp-logger-client to cdplogger-client
stefanrammo 2845852
Publish version 1.0.2 and update package.json and README
stefanrammo 67a6a55
Fix documentation
stefanrammo 5c158f8
Merge pull request #13 from CDPTechnologies/fix-documentation-discrep…
stefanrammo 62136b6
Add automatic detection to client.js between Node.js or browser
stefanrammo bd73418
Merge pull request #14 from CDPTechnologies/add-automatic-browser-nod…
stefanrammo 36bc568
Import cdplogger-client into logger/ subdirectory
stefanrammo 447cc35
Integrate logger client into cdp-client with service-based discovery
stefanrammo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have somewhere also a longer description. Either in this file or a different file. The https://github.com/CDPTechnologies/JavascriptCDPLoggerClient/blob/main/DOCUMENTATION.md had a good overview and some background into what the logger can do.
And I also liked the examples folder in the logger client repo, maybe should copy those also over here.