Added tests and fake data related to Event Tags#10
Merged
stefanrammo merged 8 commits intomainfrom Apr 4, 2025
Merged
Conversation
Karmo7
reviewed
Apr 2, 2025
client.js
Outdated
| * This method checks if the tags for the specified sender are already cached. If so, it returns a | ||
| * resolved promise with the cached tags. Otherwise, it initializes a pending promise for the sender, | ||
| * sends a request for the sender's tags using `_sendEventSenderTagsRequest`, and returns a promise that | ||
| * resolves when the tags are received. If no response is received within 5000 ms, it falls back to resolving |
Contributor
There was a problem hiding this comment.
I still think the 5000 ms timeout should be removed
Karmo7
reviewed
Apr 2, 2025
test/client.test.js
Outdated
| 1530613239.0, | ||
| 1530613270.0, | ||
| 2, // The second call's requestId | ||
| 500, // limit |
Contributor
There was a problem hiding this comment.
Isn't limit argument normally after noOfDataPoints?
Or why are the arguments here in different order than in other places.
Karmo7
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.