Skip to content

add(staff-association): new model and transformation rules#391

Open
zubeydecivelek wants to merge 1 commit into
CERNDocumentServer:masterfrom
zubeydecivelek:staff-assoc
Open

add(staff-association): new model and transformation rules#391
zubeydecivelek wants to merge 1 commit into
CERNDocumentServer:masterfrom
zubeydecivelek:staff-assoc

Conversation

@zubeydecivelek
Copy link
Copy Markdown
Contributor

@zubeydecivelek zubeydecivelek commented Mar 19, 2026

No records found with scripts/dump_legacy_recids_to_redirect.py

@zubeydecivelek zubeydecivelek linked an issue Mar 19, 2026 that may be closed by this pull request
1 task
Comment thread cds_migrator_kit/rdm/records/transform/xml_processing/rules/base.py
Comment on lines +805 to +808
"manuscript": {
"relation_type": {"id": "isderivedfrom"},
"resource_type": {"id": "publication-preprint"},
},
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it the only record? because this particular one is not a preprint

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that's the only record

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then please check with the curators what it should be, this one seems incorrect

Comment on lines +61 to +63
if value == "bulletinstaff":
# TODO what is the resource type?
return {"id": "publication-periodicalarticle"}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is resource_type correct?

Comment thread cds_migrator_kit/rdm/records/transform/xml_processing/rules/base.py
@zubeydecivelek zubeydecivelek force-pushed the staff-assoc branch 2 times, most recently from cd7693e to ec6be3c Compare May 5, 2026 16:29
@zubeydecivelek zubeydecivelek moved this to In review 🔍 in Sprint Q2 2026 ☀️ May 6, 2026
Comment thread cds_migrator_kit/rdm/records/load/load.py Outdated
"110__a", # corporate author, always CERN, safe to ignore
"300__a", # number of pages
"336__a", # DM metadata
"506__m", # 2120833, ignored with confirmation from IR-ECO-CO
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it mean we need to ask them?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore keys are copied from bulletin. But I can check them again and verify with library if it's needed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the rules, 506__m doesnt exist for staff association. But we need to figure out multiple submitters, most of the records(2595/3306) have 859__a with different values.

Comment thread cds_migrator_kit/rdm/records/transform/xml_processing/rules/staff_association.py Outdated
@zubeydecivelek zubeydecivelek force-pushed the staff-assoc branch 2 times, most recently from ae3d8bb to 2da547f Compare May 8, 2026 14:41
Comment on lines +93 to +95
_default_fields = {
# TODO should we keep this custom field?
"custom_fields": {"journal:journal": {"title": "CERN Bulletin"}},
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this custom field like bulletin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Q2 simple collections to analyse

2 participants