Fixes to RunR for the arbitrary grid#543
Merged
Merged
Conversation
Also fix dynamic field load
llaniewski
requested changes
Mar 10, 2026
llaniewski
left a comment
Member
There was a problem hiding this comment.
This is good to merge, but I would like the setFlags for completeness.
| std::vector<real_t> ArbLattice::getFieldAdj(const Model::Field& f) { throw std::runtime_error{"UNIMPLEMENTED"}; return {}; }; | ||
| void ArbLattice::setFlags(const std::vector<big_flag_t>& x) { throw std::runtime_error{"UNIMPLEMENTED"}; return; }; | ||
| void ArbLattice::setField(const Model::Field& f, const std::vector<real_t>& x) { throw std::runtime_error{"UNIMPLEMENTED"}; return; }; | ||
| void ArbLattice::setFlags(const std::vector<big_flag_t>& x) { throw std::runtime_error{"NOT SUPPORTED FOR ARB LATTICE"}; return; }; |
Member
There was a problem hiding this comment.
Please add setFlags analogous to getFlags.
Member
Author
There was a problem hiding this comment.
@llaniewski I did not implement it, because this would allow overwriting the Wall markers on nodes. Do we really want it for the arbitrary grid? I think it would the user should not try to do it
Member
|
Yeah, the user can overwrite any flags he wants. Not always will it make
sense, but no reason to block it.
…On Wed, 11 Mar 2026, 7:09 am Dmytro Sashko, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/ArbLattice.cpp
<#543 (comment)>:
> std::vector<real_t> ArbLattice::getFieldAdj(const Model::Field& f) { throw std::runtime_error{"UNIMPLEMENTED"}; return {}; };
-void ArbLattice::setFlags(const std::vector<big_flag_t>& x) { throw std::runtime_error{"UNIMPLEMENTED"}; return; };
-void ArbLattice::setField(const Model::Field& f, const std::vector<real_t>& x) { throw std::runtime_error{"UNIMPLEMENTED"}; return; };
+void ArbLattice::setFlags(const std::vector<big_flag_t>& x) { throw std::runtime_error{"NOT SUPPORTED FOR ARB LATTICE"}; return; };
@llaniewski <https://github.com/llaniewski> I did not implement it,
because this would allow overwriting the Wall markers on nodes. Do we
really want it for the arbitrary grid? I think it would the user should not
try to do it
—
Reply to this email directly, view it on GitHub
<#543 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOLE6CSCKT7PDKRXJI4HBT4QD7JFAVCNFSM6AAAAACWLLDCG2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSMRXGE4DGMZUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
Author
|
@llaniewski the failing check is some github action problems (could not check out the repo). I think this is good to merge |
Member
|
I've rerun the action and all checks are good. |
llaniewski
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly added getters and setters.
Also fixed a compilation error for the phase field, when compiling with >= c++17 .
Should be noted that for instance for scalar quantities, arbitrary grid returns 1D arrays with respect to the geometry,
whereas cartesian returns 3D arrays. For complex setup one can just use
Solver$GEOMETRY$BOUNDARYandSolver$Geometry$X(orY,Z) arrays, instead of assuming certain mesh structure.Tested by: