Skip to content

Fixes to RunR for the arbitrary grid#543

Merged
llaniewski merged 2 commits into
CFD-GO:developfrom
shkodm:arb_runr
Mar 12, 2026
Merged

Fixes to RunR for the arbitrary grid#543
llaniewski merged 2 commits into
CFD-GO:developfrom
shkodm:arb_runr

Conversation

@shkodm

@shkodm shkodm commented Mar 9, 2026

Copy link
Copy Markdown
Member

Mostly added getters and setters.

Also fixed a compilation error for the phase field, when compiling with >= c++17 .

Should be noted that for instance for scalar quantities, arbitrary grid returns 1D arrays with respect to the geometry,
whereas cartesian returns 3D arrays. For complex setup one can just use Solver$GEOMETRY$BOUNDARY and
Solver$Geometry$X(or Y, Z) arrays, instead of assuming certain mesh structure.

Tested by:

  • Running interactive RunR session for cartesian and arbitrary grid
  • Initialising droplet inside a periodic domain using RunR

@llaniewski llaniewski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge, but I would like the setFlags for completeness.

Comment thread src/ArbLattice.cpp Outdated
std::vector<real_t> ArbLattice::getFieldAdj(const Model::Field& f) { throw std::runtime_error{"UNIMPLEMENTED"}; return {}; };
void ArbLattice::setFlags(const std::vector<big_flag_t>& x) { throw std::runtime_error{"UNIMPLEMENTED"}; return; };
void ArbLattice::setField(const Model::Field& f, const std::vector<real_t>& x) { throw std::runtime_error{"UNIMPLEMENTED"}; return; };
void ArbLattice::setFlags(const std::vector<big_flag_t>& x) { throw std::runtime_error{"NOT SUPPORTED FOR ARB LATTICE"}; return; };

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add setFlags analogous to getFlags.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llaniewski I did not implement it, because this would allow overwriting the Wall markers on nodes. Do we really want it for the arbitrary grid? I think it would the user should not try to do it

@llaniewski

llaniewski commented Mar 11, 2026 via email

Copy link
Copy Markdown
Member

@shkodm

shkodm commented Mar 12, 2026

Copy link
Copy Markdown
Member Author

@llaniewski the failing check is some github action problems (could not check out the repo). I think this is good to merge

@llaniewski

Copy link
Copy Markdown
Member

I've rerun the action and all checks are good.

@llaniewski llaniewski merged commit 7320b7b into CFD-GO:develop Mar 12, 2026
58 of 59 checks passed
@shkodm shkodm deleted the arb_runr branch March 12, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants