Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces the core AuditService class, which is the main business logic layer for audit logging operations. It orchestrates creating audit log entries, querying/retrieving logs, and detecting changes between object states. The service follows a clean architecture pattern with dependency injection of port interfaces. A comprehensive test suite and a schema extension for change detection options are also included.
Changes:
- Added
AuditServiceclass with methods for logging, querying, change detection, and actor validation - Added unit tests covering all service methods, error handling, and edge cases
- Extended
CreateAuditLogWithChangesSchemawith anoptionsfield for change detection configuration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/core/audit.service.ts |
New core audit service with log, query, change detection, and validation methods |
src/core/audit.service.spec.ts |
Comprehensive Jest unit tests for the audit service |
src/core/dtos/create-audit-log.dto.ts |
Added options field to CreateAuditLogWithChangesSchema for change detection config |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Why
Checklist
npm run lintpassesnpm run typecheckpassesnpm testpassesnpm run buildpassesnpx changeset) if this affects consumersNotes