Better type hints and overloads signatures for ImpactFuncSet#1250
Merged
Better type hints and overloads signatures for ImpactFuncSet#1250
Conversation
spjuhel
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
peanutfun
requested changes
Feb 13, 2026
Member
peanutfun
left a comment
peanutfun
left a comment
There was a problem hiding this comment.
One tiny thing, then it's good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
I was annoyed by my LSP saying get_func return a dict[Unknown, Unknown]
This PR adjusts a few type hints and some overloads statement for get_func. (This tells LSP what is the return type of get_func() for different inputs).
PR Author Checklist
develop)PR Reviewer Checklist