Open
Conversation
The interfaces are off, this is just one example
Author
|
By editing the wrong line, committing it, fixing it and committing it again maybe the lines I marked are unclear. Original code: Changed code: |
Owner
|
This is not a failure by the interface translation itself. It's an compiler issue. See here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's one example of how the implementation is wrong.
My change works as it should.
The original declaration comes with "D2D DEBUG ERROR - An interface [0019F388] not allocated by this DLL was passed to it."
GetPixelSize is a stdcall function.
stdcall pushes the parameters to the stack and returns the result in EAX.
In your implementation a (semi) random value from the stack is used as the parameter, the D2D DEBUG ERROR is correct about it not being an interface allocated by this DLL.
Same goes for GetSize and GetPixelFormat in this ID2D1Bitmap interface.