This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Open
Conversation
Pulling backend from upstream
This button sends a GET request to the new API endpoint by Dimitris.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have added the new "Discover file" button in Histogram File Manager page. The button is simple: click on it, and a modal shows up for confirmation with another button to discover files. With this modal, we can add another text field asking the user to add their authentication token, because at this point I am not sure how we can associate API tokens to each front-end users logging in using CERN accounts.
I also found out that once the second button is clicked, a GET request will be sent with CSRF token in it. (I suspect that is provided by Axios JS library I am using.) However, I could not check if the requests are legitimate on the developer instance.
The button I have right now is very primitive, but I am sure we can iterate on this and make file discovery on EOS to be a breeze on the front-end.
Thanks,
Vichayanun