Skip to content

Make CLI/logging dependencies optional behind a cli feature #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjfields wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make CLI/logging dependencies optional behind a cli feature #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,21 @@ edition = "2024"
rust-version = "1.91"

[features]
default = ["mimalloc-alloc"]
mimalloc-alloc = ["mimalloc"]
# `cli` pulls in everything the `align_benchmark` binary needs (argument
# parsing + logging). It is in `default` so `cargo build`/`cargo run` keep
# producing the benchmark binary as before. Library consumers should depend
# with `default-features = false` to avoid the CLI/logging dependency tree.
default = ["cli", "mimalloc-alloc"]
cli = ["dep:clap", "dep:tracing", "dep:tracing-subscriber"]
mimalloc-alloc = ["dep:mimalloc"]

[dependencies]
clap = { version = "4", features = ["derive"] }
# All four are binary-only (used solely under src/bin/), so they are optional
# and enabled via features rather than imposed on library consumers.
clap = { version = "4", features = ["derive"], optional = true }
mimalloc = { version = "0.1", optional = true }
tracing = "0.1"
tracing-subscriber = "0.3"
tracing = { version = "0.1", optional = true }
tracing-subscriber = { version = "0.3", optional = true }

[profile.release]
lto = true
Expand All @@ -22,3 +29,6 @@ panic = "abort"
[[bin]]
name = "align_benchmark"
path = "src/bin/align_benchmark.rs"
# The binary needs the CLI dependency stack; skip it for library-only builds
# (e.g. `--no-default-features`).
required-features = ["cli"]