Skip to content

Add _space_group.reference_setting _space_group.transform_Pp_abc _space_group.transform_Qq_xyz#628

Merged
vaitkus merged 12 commits into
COMCIFS:mainfrom
rowlesmr:add-remaining-symCIF
Jul 15, 2026
Merged

Add _space_group.reference_setting _space_group.transform_Pp_abc _space_group.transform_Qq_xyz#628
vaitkus merged 12 commits into
COMCIFS:mainfrom
rowlesmr:add-remaining-symCIF

Conversation

@rowlesmr

@rowlesmr rowlesmr commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

From COMCIFS/cif_mag#75 (comment)

Added

  • _space_group.reference_setting
  • _space_group.transform_Pp_abc
  • _space_group.transform_Qq_xyz

with text taken from from https://www.iucr.org/__data/iucr/cif/dictionaries/cif_sym_1.0.1.dic

Updated first URL in second reference in _space_group.reference_setting

Probably need to update ITA reference in _space_group.reference_setting, but I don't have access to latest copy.

I took an educated guess at the _type.* values.

Should the enumeration go into templ_enum.cif?

Comment thread cif_core.dic Outdated
@vaitkus

vaitkus commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Thank you for taking on the PR. I just discovered that there is a draft version of the DDLm symCIF dictionary that might prove useful (see https://github.com/COMCIFS/comcifs.github.io/blob/main/draft/cif_sym.dic).

@rowlesmr

Copy link
Copy Markdown
Collaborator Author

That is helpful!

@rowlesmr

rowlesmr commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

Differences from https://github.com/COMCIFS/comcifs.github.io/blob/main/draft/cif_sym.dic

This PR:

  • _type.contents Text for reference_setting. The enumerations are described as '_space_group.IT_number:_space_group.name_Hall'. The _type.contents of _space_group.name_hall is Text
  • _type.purpose Encode for transform_*, mirroring that of the symops, as information is encoded in a machine-readable manner in the value.
  • AFAIK the _description_example.case/detail are in the correct order

Comment thread cif_core.dic Outdated

@jamesrhester jamesrhester left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

Comment thread cif_core.dic Outdated
rowlesmr added 2 commits July 14, 2026 21:51
as I don't think there's been a release with this in it, it should be OK to remove.
Comment thread cif_core.dic Outdated
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
@vaitkus
vaitkus merged commit f559391 into COMCIFS:main Jul 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants