Add _space_group.reference_setting _space_group.transform_Pp_abc _space_group.transform_Qq_xyz#628
Merged
Merged
Conversation
vaitkus
reviewed
Jul 10, 2026
Collaborator
|
Thank you for taking on the PR. I just discovered that there is a draft version of the DDLm symCIF dictionary that might prove useful (see https://github.com/COMCIFS/comcifs.github.io/blob/main/draft/cif_sym.dic). |
Collaborator
Author
|
That is helpful! |
Collaborator
Author
|
Differences from https://github.com/COMCIFS/comcifs.github.io/blob/main/draft/cif_sym.dic This PR:
|
vaitkus
reviewed
Jul 14, 2026
as I don't think there's been a release with this in it, it should be OK to remove.
vaitkus
reviewed
Jul 14, 2026
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
vaitkus
approved these changes
Jul 15, 2026
jamesrhester
approved these changes
Jul 15, 2026
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From COMCIFS/cif_mag#75 (comment)
Added
_space_group.reference_setting_space_group.transform_Pp_abc_space_group.transform_Qq_xyzwith text taken from from https://www.iucr.org/__data/iucr/cif/dictionaries/cif_sym_1.0.1.dic
Updated first URL in second reference in
_space_group.reference_settingProbably need to update ITA reference in
_space_group.reference_setting, but I don't have access to latest copy.I took an educated guess at the
_type.*values.Should the enumeration go into templ_enum.cif?