Rename dictionary to CIF_CORE_MULTIBLOCK#35
Merged
jamesrhester merged 2 commits intoJun 18, 2026
Conversation
Collaborator
Author
|
This PR should not be merge until the official name of the dictionary file is agree upon (see #36). |
vaitkus
marked this pull request as draft
August 14, 2025 17:43
vaitkus
force-pushed
the
adopt-standard-dictionary-name
branch
from
December 1, 2025 09:01
f827bcb to
69e32ed
Compare
vaitkus
force-pushed
the
adopt-standard-dictionary-name
branch
from
June 17, 2026 08:13
69e32ed to
71624fa
Compare
vaitkus
changed the title
vaitkus
marked this pull request as ready for review
June 17, 2026 08:27
jamesrhester
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dictionary is renamed following the conventions discussed in COMCIFS/cif_core#488.
It would be good to adopt before making the official release of the
pdCIFdictionary that imports it so that the name would not need to be changed in the future releases.