change to 'save':structure_id_key#65
Merged
Merged
Conversation
There is a mixture of originally linked to _structure.id and originally linked to _<parent>.structure_id. I made them all link to parent.
jamesrhester
left a comment
jamesrhester
left a comment
Contributor
There was a problem hiding this comment.
Imports pointing to the 'no-linked' version should only be used where both parent and child categories are looped.
…ategories are looped. Removed linked_item_id entries from multiple definitions in cif_core_multiblock.dic.
jamesrhester
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Altered save frame text to pull from templ_attrs.cif as per discussion in COMCIFS/cif_ms#68 (review)
_model.structure_id left alone as it is a non-key data name.