Skip to content

Add proper imgCIF imports #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesrhester merged 2 commits into from
May 27, 2026
Merged

Add proper imgCIF imports #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c5a68e
Update imgCIF import statement to use a local copy
vaitkus May 6, 2026
2c9f034
Initiate new development version so that the date could be changed
vaitkus May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,18 @@ jobs:
repository: COMCIFS/cif_core
path: cif-dictionaries/cif_core

- name: Check out the multiblock coreCIF dictionary
uses: actions/checkout@v6
with:
repository: COMCIFS/cif_multiblock
path: cif-dictionaries/cif_multiblock

- name: Check out the DDLm imgCIF dictionary
uses: actions/checkout@v6
with:
repository: COMCIFS/imgCIF
path: cif-dictionaries/imgCIF

- name: Run dictionary validity checks
uses: COMCIFS/dictionary_check_action@main
id: ddlm_check
Expand Down
15 changes: 11 additions & 4 deletions draft_new_items.dic
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ data_DRAFT_NEW_ITEMS

_dictionary.title DRAFT_NEW_ITEMS
_dictionary.class Instance
_dictionary.version 0.0.10
_dictionary.date 2025-03-24
_dictionary.version 0.0.11-dev
_dictionary.date 2026-05-06
_dictionary.uri
https://raw.githubusercontent.com/COMCIFS/cif_ed/main/draft_new_items.dic
_dictionary.ddl_conformance 4.2.0
Expand Down Expand Up @@ -48,8 +48,8 @@ save_DRAFT_NEW_ITEMS_HEAD
_import.get
[
{'dupl':Ignore
'file':https://github.com/COMCIFS/imgCIF/blob/master/cif_img.dic
'mode':Full 'save':HEAD}
'file':cif_img.dic
'mode':Full 'save':CIF_IMG_HEAD}
]

save_
Expand Down Expand Up @@ -199,4 +199,11 @@ save_
handled in a cif_img.dic context or else elaborated with more
precise definitions and indications where relevant only to
electron diffraction.
;
0.0.11-dev 2026-05-06
;
# Please update the date above and describe the change below until
# ready for the next release

Initialised new development version.
;