CALCULATOR APPLICATION using HTML,Vanilla JS and CSS#49
Open
vaibhav-1508 wants to merge 7 commits intoCOPS-CSOC-2022:masterfrom
Open
CALCULATOR APPLICATION using HTML,Vanilla JS and CSS#49vaibhav-1508 wants to merge 7 commits intoCOPS-CSOC-2022:masterfrom
vaibhav-1508 wants to merge 7 commits intoCOPS-CSOC-2022:masterfrom
Conversation
S-kus
approved these changes
Jun 30, 2022
Member
There was a problem hiding this comment.
Hey @vaibhav-1508, Great work! Clean and simple UI and nice implementation of all tasks.
However, there are a few scopes of improvements:
- in mobile view, your theme changing is not working.
- History part is not responsive.
Also, you can try to implement task 3 and learn the basics of working with git. Would be helpful for you.
Author
Thank you for your suggestions! I'll surely make improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSOC Task 1 Submission
Track
Task Completed
Hangman
Calculator
Submission
Repo
APK|Web Site