Open
Conversation
S-kus
approved these changes
Jun 30, 2022
Member
S-kus
left a comment
There was a problem hiding this comment.
Hey @AyushJ16, great work! Clean code, simple UI and nice implementation of tasks., However, there are a few scopes of improvements like the responsiveness of the web app and better UI (on changing the theme, it should change more UI rather than just changing the background).
You can try to implement the bonus task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSOC Task 1 Submission
Track
Task Completed
Calculator
Submission
Repo
APK|Web Site