finally added hangman late by Vani#60
Open
VaniThapar wants to merge 1 commit intoCOPS-CSOC-2022:masterfrom
Open
finally added hangman late by Vani#60VaniThapar wants to merge 1 commit intoCOPS-CSOC-2022:masterfrom
VaniThapar wants to merge 1 commit intoCOPS-CSOC-2022:masterfrom
Conversation
S-kus
approved these changes
Jun 30, 2022
Member
S-kus
left a comment
There was a problem hiding this comment.
Hey @VaniThapar! Nice work,Clean and simple UI and nice implementation of all tasks. However there are few scope of improvements:
- responsiveness of the webapp,
- Easy mode is not working properly.
It's good that you have implemented it again, but i guess you need to remove extra copies of .js and .HTML file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSOC Task 1 Submission
Track
Task Completed
Hangman
Calculator
Submission
Repo
Web Site