Open
Conversation
Author
|
Is it working fine? |
Collaborator
|
Nope @atulyadav745! The changes you have made are commented. Moreover, add the links in the PR description above as well :) |
Author
Author
S-kus
approved these changes
Jul 19, 2022
Member
There was a problem hiding this comment.
Hey @atulyadav745, Good work! Clean code and simple UI. However, there are a few scopes of improvements like the responsiveness of the web app, and color choices. Also, your task 3 (Giving hints to users) is not working as expected.
You can try to implement task 2 as well, this would be helpful for you. Also, it will help you to explore other options to restart the game rather than reloading the page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSOC Task 1 Submission
Track
Task Completed
Hangman
Calculator
Submission
Repo
APK|Web Site