Hotfix/fix page sizing ntu#91
Merged
Merged
Conversation
…o feature/code-editor-swey
…so using it in signin and signup pages, also added logic to onLogout to make sure signOut is called properly
…normal to tailwind
…Clash into hotfix/fix_page_sizing-ntu
…o hotfix/fix_page_sizing-ntu
…o testing-swey
…Clash into hotfix/fix_page_sizing-ntu
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
removed debugging Signed-off-by: Swelihle Makhathini <u24584585@tuks.co.za>
Signed-off-by: Swelihle Makhathini <u24584585@tuks.co.za>
Signed-off-by: Swelihle Makhathini <u24584585@tuks.co.za>
|
nsmzoneli
approved these changes
May 22, 2026
Contributor
nsmzoneli
left a comment
nsmzoneli
left a comment
There was a problem hiding this comment.
We recognise the code coverage check is not enough. In order to have the important fixes in this PR, we will carry over the coverage into out next sprint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed signin and signout issues, also changed some of the css to tailwind in order to fix the scaling issues that were causing webpages to not be proportionate and look well. Also added a preliminary SRS document.
Related issue
Cognito Sign and SignOut, CSS Tailwind, SRS Documentation
How to test
"npm test" in front end