Skip to content

Two-stage common envelope formalism from Hirai & Mandel 2022#805

Open
TristanBruel wants to merge 5 commits into
COSMIC-PopSynth:developfrom
TristanBruel:develop
Open

Two-stage common envelope formalism from Hirai & Mandel 2022#805
TristanBruel wants to merge 5 commits into
COSMIC-PopSynth:developfrom
TristanBruel:develop

Conversation

@TristanBruel

Copy link
Copy Markdown

Ciao!
Here is a proposed implementation in COSMIC of the two-stage common envelope formalism presented in Hirai & Mandel 2022.
It basically relies on the idea that only the convective part of the envelope should be involved in the common envelope phase, and, if present, the radiative intershell more tightly bound to the core should only be lost through a stable mass transfer.

  • When using SSE, it is based on fits from Picker, Hirai & Mandel 2024 to compute the mass of the convective envelope and its binding energy.
  • When using METISSE, the mass of the convective envelope is directly interpolated from the stellar tracks via mass_conv_envelope
    It is worth noting that COSMIC technically already computes the mass of the convective envelope via the MRENV subroutine, but I could not find where these fits come from (I believe it is not from Hurley et al 2000).
    Cheers,
    Tristan Bruel

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 13.79310% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.11%. Comparing base (8772c07) to head (7c90e6b).
⚠️ Report is 176 commits behind head on develop.

Files with missing lines Patch % Lines
src/cosmic/src/comenv.f 21.43% 44 Missing ⚠️
src/cosmic/src/SSE/SSE_zfuncs.f 0.00% 31 Missing ⚠️

❌ Your patch check has failed because the patch coverage (13.79%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #805       +/-   ##
============================================
- Coverage    86.91%   76.11%   -10.80%     
============================================
  Files           40       59       +19     
  Lines        25542    28195     +2653     
  Branches         0      991      +991     
============================================
- Hits         22198    21460      -738     
- Misses        3344     6430     +3086     
- Partials         0      305      +305     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant