Two-stage common envelope formalism from Hirai & Mandel 2022#805
Open
TristanBruel wants to merge 5 commits into
Open
Two-stage common envelope formalism from Hirai & Mandel 2022#805TristanBruel wants to merge 5 commits into
TristanBruel wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (13.79%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #805 +/- ##
============================================
- Coverage 86.91% 76.11% -10.80%
============================================
Files 40 59 +19
Lines 25542 28195 +2653
Branches 0 991 +991
============================================
- Hits 22198 21460 -738
- Misses 3344 6430 +3086
- Partials 0 305 +305 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ciao!
Here is a proposed implementation in COSMIC of the two-stage common envelope formalism presented in Hirai & Mandel 2022.
It basically relies on the idea that only the convective part of the envelope should be involved in the common envelope phase, and, if present, the radiative intershell more tightly bound to the core should only be lost through a stable mass transfer.
It is worth noting that COSMIC technically already computes the mass of the convective envelope via the MRENV subroutine, but I could not find where these fits come from (I believe it is not from Hurley et al 2000).
Cheers,
Tristan Bruel