Proposed fix to typo in Eggleton approximation for RLO in independent.sample_porb#806
Open
nweatherford wants to merge 1 commit into
Open
Proposed fix to typo in Eggleton approximation for RLO in independent.sample_porb#806nweatherford wants to merge 1 commit into
nweatherford wants to merge 1 commit into
Conversation
Fixed a typo in the Eggleton approximation for Roche Lobe overflow. Someone forgot to put parentheses about the (1/3) exponent in the log term of the denominator. So instead of being log(1+q**(2/3)), as it's supposed to be, the term was previously log(1+q**1/3) == log(1+q/3).
nweatherford
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects an apparent typo in the Eggleton approximation for Roche Lobe overflow in sample_porb, when computing the minimum porb for the sampler. Specifically, there were no parentheses around the (1/3) exponent in the log term of the denominator. So instead of being log(1+q**(1/3)), as it's supposed to be, the term has been log(1+q**1/3) == log(1+q/3). The resulting R_L can be be smaller by nearly an order of magnitude for q = 0.1; this may imply the sampler has been starting out with too few near-contact binaries for significantly asymmetric mass ratios.
Note: I don't know why the unit test failed. This edit runs fine for me on Quest.