Ensure random seeds are unique for multiprocessed sampling#807
Open
TomWagg wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #807 +/- ##
============================================
- Coverage 86.91% 76.47% -10.44%
============================================
Files 40 59 +19
Lines 25542 28046 +2504
Branches 0 919 +919
============================================
- Hits 22198 21447 -751
- Misses 3344 6295 +2951
- Partials 0 304 +304 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title tells you what's up mostly, I messed up the sampling in v3.7.6 because multiprocessing workers need to be initialised with their own random seeds. I offset each worker by the process ID now so all should be fine. I've also added a test to ensure this doesn't happen again :)