added cost tracking #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Mr-Cool-in-Git
left a comment
Mr-Cool-in-Git
left a comment
There was a problem hiding this comment.
Прогнал ноутбук, все ок
Давай его оформим как демонстративный для всех
Переведи комментарии на англ + там есть опечатка
- добавь комменты к ноуту что считаешь нужным
Вопросы к МР
- Тестировал ли на других моделях кроме OpenAI?
coolprompt/language_model/tracker.py
Outdated
| self.stats["invoke_calls"] += 1 | ||
| else: | ||
| self.stats["batch_calls"] += 1 | ||
| self.stats["batch_items"] += kwargs.get("batch_size", 0) |
Collaborator
There was a problem hiding this comment.
почему по дефолту batch_size = 0, если произошел сам вызов модели?
| @@ -0,0 +1,113 @@ | |||
| from langchain_community.callbacks import get_openai_callback | |||
Collaborator
There was a problem hiding this comment.
все новые классы и методы нужны обернуть докстрингами по Google Style Code (посмотри как у нас в других скриптах)
coolprompt/language_model/tracker.py
Outdated
| from langchain_core.language_models.chat_models import BaseChatModel | ||
| from langchain_core.messages import BaseMessage | ||
| from langchain_openai import ChatOpenAI | ||
| from typing import Any |
Collaborator
There was a problem hiding this comment.
вынеси на самый верх from typing import Any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.