Skip to content

Conversation

@Elan456
Copy link
Contributor

@Elan456 Elan456 commented Jan 29, 2026

Description

Introducing a Clang Tidy workflow to maintain a tidy codebase, utilizing the Native workflow already set up by Logan.
This PR also cleans up several modules to remove all current Clang Tidy warnings so we can start fresh.

Summary of Changes

  • Add Clang Tidy workflow for PRs
  • Change #include order for several modules
  • Major refactor and clean up of the telemetry module
  • Minor changes in BurnoutStateMachine and GroundLevelEstimator to make Clang-Tidy happy (removing magic numbers, changing double to float, etc...)

Motivation

  • To maintain consistent code style and avoid common pitfalls
  • Clang Tidy can be run manually within native using pio check but it is slow, so having a workflow deal with it makes it automatic and mandatory
  • Instead of occasional giant PRs like this one, the workflow ensures that big clang-tidy issues don't build up over time.

Testing

  • I adjusted the telemetry tests in Native

Check all that apply:

  • I have added or modified tests to cover these changes.
  • I have manually tested the changes on the target device(s) or environment(s).
  • Existing tests were reviewed to ensure they still work as expected.
  • If tests were not added or modified, explain why:

    (Provide reasoning here)


Building

  • This change successfully builds in at least one of the following environments:
    • Native repo
    • Target device(s) (e.g., MARTHA)
  • If the build fails in any environment, explain why:

    (Provide reasoning here)


Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code where necessary for clarity.
  • I have made corresponding updates to documentation (if applicable).

Jshepherd06 and others added 25 commits October 1, 2025 18:38
@Elan456 Elan456 requested a review from jstikel January 29, 2026 03:20
@Elan456 Elan456 merged commit 27fb980 into main Jan 31, 2026
2 checks passed
@Elan456 Elan456 deleted the chore/clang-tidy-workflow branch January 31, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants