-
Notifications
You must be signed in to change notification settings - Fork 1
Clang Tidy Workflow + Telemetry Clean Up #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fastlaunchdetector
…into fastlaunchdetector
… machine when no confirmation
…into fastlaunchdetector
…into fastlaunchdetector
…nics into fastlaunchdetector
…into fastlaunchdetector
…eering/Avionics into fastlaunchdetector
…into chore/clang-tidy-workflow
Fastlaunchdetector
…etEngineering/Avionics into chore/clang-tidy-workflow
…ketEngineering/Avionics into chore/clang-tidy-workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a Clang Tidy workflow to maintain a tidy codebase, utilizing the Native workflow already set up by Logan.
This PR also cleans up several modules to remove all current Clang Tidy warnings so we can start fresh.
Summary of Changes
#includeorder for several modulesBurnoutStateMachineandGroundLevelEstimatorto make Clang-Tidy happy (removing magic numbers, changing double to float, etc...)Motivation
pio checkbut it is slow, so having a workflow deal with it makes it automatic and mandatoryTesting
telemetrytests in NativeCheck all that apply:
Building
Checklist