Misc. minor repository fixups. #1616
Conversation
Put it into the .github folder instead of the top-level folder of the repo. Signed-off-by: Andrew Lilley Brinker <abrinker@mitre.org>
This makes some basic Python code quality improvements to the 5.0 upload script. Signed-off-by: Andrew Lilley Brinker <abrinker@mitre.org>
This corrects some broken Markdown in the test README file, and also removes some incorrect information about pre-push hooks that don't exist. Signed-off-by: Andrew Lilley Brinker <abrinker@mitre.org>
The `action:test` script previously did not set the `NODE_ENV` environment variable, which caused warnings to be emitted by winston, our logging library, indicating that it had nowhere to send the logs it was producing. This is because the log initialization code in cve-services checks `NODE_ENV` to figure out how to configure the "transport" (Winston's term for a log sink), so without `NODE_ENV` being set, the transport is never configured. This fix just sets the environment variable, causing the warnings to disappear. Signed-off-by: Andrew Lilley Brinker <abrinker@mitre.org>
|
Looks like tests are failing due to a networking issue connecting to MITRE's artifact repository. Will have to investigate. |
|
Ah, it seems MITRE's changes to NPM are breaking the build here, because |
alilleybrinker
force-pushed
the
alilleybrinker/minor-fixups
branch
from
e946d0c to
b6f9b51
Compare
Did three things: - Ran `npm run clean` to identify unused deps. Confirmed each is unused manually before removing. - For two false positives, modified the `clean` command to ignore them. - Renamed the `clean` command to `depcheck`, to more accurately describe what it's doing. Signed-off-by: Andrew Lilley Brinker <abrinker@mitre.org>
Several NPM scripts were duplicative of others, and have been removed. This also reorders scripts to make sure the ordering is more consistent. Signed-off-by: Andrew Lilley Brinker <abrinker@mitre.org>
This info said to run a command that doesn't exist. This also introduces a guide for running integration tests. Signed-off-by: Andrew Lilley Brinker <abrinker@mitre.org>
Felt odd to have a script sitting in the root of the repo. This relocates it to `src/scripts/`, which is technically odd because it's a Python script not a JavaScript one, but this is already a grab-bag of miscellaneous scripts that get run during development, so I think it's fine. Signed-off-by: Andrew Lilley Brinker <abrinker@mitre.org>
This also cleans up the Markdown formatting of the top-level project README.md. Signed-off-by: Andrew Lilley Brinker <abrinker@mitre.org>
alilleybrinker
force-pushed
the
alilleybrinker/minor-fixups
branch
from
b6f9b51 to
327469b
Compare
|
I figured out the right incantation to fully clear Artifactory mentions, so packages should now all pull from NPM properly. |
|
Huh, for some reason the tests were hanging after an hour and a half with a MongoDB error that was not causing the test infrastructure to give up. That tells me:
|
|
MongoDB issue observed in prior runs appears to be transient and non-reproducible on my local device. I'm hopeful it's just a GitHub Actions issue that will disappear on a retry now that it's been about a week. |
|
Nope, errors still appearing. Mongo is claiming that it's trying to use a session that's ended. Time to dive into debugging then! |
Did these concurrent with my work on the new authz API. The fixups are organized by-commit, so reviewing by-commit might be easier. Opted to bundle them into a single PR to make review simpler; happy to split them out if that's preferable.
The changes are:
.github/folder.NODE_ENV=testconsistently on unit tests.src/scripts/replSetfor MongoDB to work correctly.