fix(boost): guard empty boost_parallel / max_records_per_select against div-by-zero#7181
Closed
somethingwithproof wants to merge 2 commits into
Closed
Conversation
…ct config When boost_parallel or boost_rrd_update_max_records_per_select is unset (fresh upgrade, manual settings edit, plugin reset), ceil($n / 0) yields INF (or DivisionByZeroError on PHP 8) and downstream LIMIT 0 selects nothing, dropping the boost block. Default empties to 1 / 50000 to match the existing guard in boost_launch_children. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds defensive defaults for Boost poller configuration values to prevent invalid runtime behavior when config options are unset/empty.
Changes:
- Default
boost_parallelto1when empty - Default
boost_rrd_update_max_records_per_selectto50000in two code paths
…shifts Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
boost_parallelorboost_rrd_update_max_records_per_selectis unset (fresh upgrade, manual settings edit, plugin reset),ceil($n / $processes)/ceil($total_rows / $max_per_select)is a divide-by-zero (INF on 7.4, DivisionByZeroError on 8.x), and the downstreamLIMIT 0selects nothing — silently dropping the boost block. Addsempty()defaults (1 / 50000) inboost_prepare_process_table,boost_process_local_data_ids, andboost_rrdtool_function_update, matching the guard already present inboost_launch_children. Base: 1.2.x.