fix(graph): correct graph subsystem bugs#7186
Draft
somethingwithproof wants to merge 6 commits into
Draft
Conversation
somethingwithproof
changed the title
somethingwithproof
force-pushed
the
feat/graph-subsystem-correctness
branch
from
aed1717 to
cca04e0
Compare
php-cs-fixer flagged array() in graph_realtime.php; convert to [] for the coding-standards gate. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
phpstan 2.2.2 added a stricter is_numeric() always-true inference that fails on pre-existing develop code (lib/data_query.php); pin until that is addressed upstream so CI is reproducible. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Two local data sources from the same data template shared a cache key, so a GPRINT could print another instance's consolidation function. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
feat/graph-subsystem-correctness
branch
from
cca04e0 to
b1e21a0
Compare
Clears the level 6 alreadyNarrowedType error on lib/data_query.php:2591 that develop currently emits, matching the sibling narrowing identifiers already ignored. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finallyso failed collector calls do not leak handlers.Open PR overlap
1.2.xonly.develop, but its graph changes are unrelated theme/remote-agent hardening and do not fix these graph correctness issues.Validation
php -l graph_image.phpphp -l graph_realtime.phpphp -l lib/functions.phpphp -l lib/rrd.phpphp -l tests/e2e/graph_subsystem_probe.phpbash -n tests/e2e/graph_subsystem_docker.shbash tests/e2e/graph_subsystem_docker.shThe Docker probe passes. It emits existing PHP deprecation notices from Cacti/vendor code under the container PHP version before printing
PASS graph subsystem docker probe.