harden CSV encoding and process execution handling

[somethingwithproof]

Routes CSV export cells through a shared cacti_csv_cell() helper so values containing quotes, commas, or leading formula characters round-trip correctly across the graph, color, device, and discovery exporters.

Adds defensive guards on the process-execution paths:

• is_resource() checks before reading proc_open pipes (cmd, cmd_realtime, remote_agent, dsstats, rrdcheck), falling back to the existing direct path on spawn failure
• captured and checked exec exit codes in SNMP gets and exec_into_array
• per-argument escaping for the snmptrap sender (array form via exec_background) and the rrdtool CLI dump paths
• non-predictable spikekill temp file names and guarded unlinks

No functional change to success paths. All touched files pass php -l.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR focuses on hardening command execution, SQL construction, and CSV/HTML output handling to reduce injection risk and improve robustness when external processes fail to spawn.

Changes:

• Add safer escaping/casting for shell commands and improve handling of proc_open()/popen() failures.
• Introduce CSV cell encoding to mitigate spreadsheet formula injection and apply it across exports.
• Add SQL helpers/quoting to reduce injection risk in query filters and IN (...) clauses.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
script_server.php	Casts Windows PID to int before using it in TASKLIST command.
remote_agent.php	Avoids reading from pipes when proc_open() fails; adds fallback logging.
lib/spikekill.php	Uses stronger randomness for temp naming; logs RRDtool dump failures.
lib/snmpagent.php	Builds snmptrap args as tokens (array) to reduce shell-splitting/injection risk.
lib/snmp.php	Captures exec() return code to detect SNMP failures beyond “Timeout” text.
lib/rrdcheck.php	Guards against proc_open() failure before using pipes.
lib/rrd.php	Logs RRDtool launch failures when popen() returns false.
lib/reports.php	Escapes report runner command before execution.
lib/html_graph.php	Quotes regex filter and uses a safe IN-clause helper.
lib/html.php	Integer-coerces graph template ids and DB-derived template ids.
lib/graph_variables.php	Skips non-finite datapoints in summation; avoids undefined percentile index.
lib/functions.php	Extends exec_into_array() to return exit code; adds cacti_csv_cell().
lib/dsstats.php	Guards against proc_open() failure before using pipes.
lib/database.php	Adds db_in_clause() helper for safer IN (...) predicates.
lib/boost.php	Escapes configured PHP binary path before building command line.
lib/auth.php	Skips empty/invalid CSV mapping lines when resolving basic auth usernames.
install/functions.php	Uses CSV parsing for color import; uses parameter binding consistently for read_only.
host.php	Adds CSV formula-trigger prefixing to exported host fields.
graph_xport.php	Uses cacti_csv_cell() for CSV export; HTML-escapes table headers/unexpected values.
color.php	Uses cacti_csv_cell() in color CSV export.
cmd_realtime.php	Adds proc_open() failure handling before reading pipes.
cmd.php	Adds proc_open() failure handling before reading pipes; logs fallback.
cli/splice_rrd.php	Escapes RRDtool command and arguments passed to shell_exec().
cli/migrate_poller.php	Removes separate rollback CSV output; updates messages/help to reflect new behavior.
automation_devices.php	Uses cacti_csv_cell() throughout discovery results CSV export.