ci: ignore phpstan function.alreadyNarrowedType identifier#7208
Open
somethingwithproof wants to merge 1 commit into
Open
ci: ignore phpstan function.alreadyNarrowedType identifier#7208somethingwithproof wants to merge 1 commit into
somethingwithproof wants to merge 1 commit into
Conversation
is_numeric() on a value PHPStan already narrows to numeric (lib/data_query.php:2591) trips alreadyNarrowedType, the same class of narrowing complaint already ignored for the if/equal/identical identifiers above. Add it so level 6 analysis passes. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates PHPStan configuration to suppress an additional static analysis finding.
Changes:
- Adds
function.alreadyNarrowedTypeto the list of ignored PHPStan error identifiers.
| - identifier: identical.alwaysFalse | ||
| - identifier: booleanAnd.leftAlwaysTrue | ||
| - identifier: booleanAnd.leftAlwaysFalse | ||
| - identifier: function.alreadyNarrowedType |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
develop is failing the Cacti Commit Audit (PHP 8.1-8.4) at level 6:
.phpstan.neonalready ignores the matching narrowing identifiers (if.alwaysTrue,equal.alwaysTrue,identical.alwaysTrue, thebooleanAnd.*pair, etc.) under the "PHPStan gets confused" group.function.alreadyNarrowedTypeis the same class of complaint for built-in predicates and was the only one missing. Adding it turns the audit green.No code behavior change.