Godot 4.2 Port, it need a little rework to fix animations#2
Open
velteyn wants to merge 1 commit into
Open
Conversation
|
Hi, you've done a great job on this except the mess you've add in your commit will never allow this PR to go further unfortunately. You'd need to clean-up the 'rubbish' folder and temporary files out first, at least. I'm a bit less unhappy to see someone as messy as I can be myself. By the way, have you look to fix the reels issue ? I first thought it was on you too (my bad), but it also happened with base version of the project and makes all first four reels produce the same item: bats replace anything originally there I guess, which completely kills the project itself IMHO. Visual is good but it won't be enough to be useful in an actual game :|. Also, tested on v4.3.beta1.official [a4f2ea91a] and still work well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to convert this project to Godot 4.2.2 Stable.
The ending animation is not working correctly
The rest works