Fix tests for UFO config#1
Closed
ScottyVenable wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the configuration test suite to use assert statements instead of returning boolean flags, adds graceful handling when optional configs are missing, and standardizes print formatting.
- Replace return-based test flow with
assert successin main and dataflow config tests - Handle missing config directories and data gracefully by early return
- Update the
maintest runner to catch exceptions and aggregate results
Comments suppressed due to low confidence (2)
UFO/test_config.py:145
- The
assert Trueat the end oftest_env_filesmakes this test always pass, even when no env files are found. Consider usingpytest.skip("No .env files found")for optional behavior or add a meaningful assertion to validate required files.
assert True
UFO/test_config.py:178
- The
assert Trueintest_environment_variablesdoes not verify that any environment variables are actually set. Either assert onfound_varsor skip the test when none are expected, to ensure the test catches missing variables.
assert True
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pytest -qhttps://chatgpt.com/codex/tasks/task_e_68617afc3f40833297a6ec32893926b4