Fix tests for UFO config#2
Open
ScottyVenable wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR patches the test suite for the UFO configuration by replacing returning boolean values with assertions and handling missing configuration scenarios gracefully. Additionally, it updates the documentation to include troubleshooting notes and specify Windows-only requirements.
- Utilizes assertions instead of return statements in test functions to indicate test outcomes.
- Handles missing config/dataflow config gracefully by printing warnings before assertion.
- Updates README.md with troubleshooting instructions and Windows-specific dependency notes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| UFO/test_config.py | Revised tests to use assertions; some functions still use early returns leading to inconsistent test outcomes. |
| README.md | Added troubleshooting and Windows-specific dependency notes to assist users encountering ModuleNotFoundError. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pytest -qpython main.py(fails: ModuleNotFoundError: No module named 'win32api')https://chatgpt.com/codex/tasks/task_e_68617afc3f40833297a6ec32893926b4